Skip to content

Ascent build system based on LLVM clang#103

Merged
pelesh merged 1 commit intodevelopfrom
nicholson/ascent-llvm
Dec 18, 2023
Merged

Ascent build system based on LLVM clang#103
pelesh merged 1 commit intodevelopfrom
nicholson/ascent-llvm

Conversation

@nkoukpaizan
Copy link
Copy Markdown
Collaborator

This PR adds the ascent-llvm CMake preset to build with LLVM clang on Ascent.

Closes #13

@nkoukpaizan
Copy link
Copy Markdown
Collaborator Author

There was a failing test on Ascent earlier. It passed when I re-ran, but that raises some flags for me.

@pelesh
Copy link
Copy Markdown
Collaborator

pelesh commented Dec 6, 2023

There was a failing test on Ascent earlier. It passed when I re-ran, but that raises some flags for me.

This example is nondeterministic due to algorithm used in cusolverRf library. We need to figure out how to set better pass/fail criteria for that test. Thanks for flagging it.

@nkoukpaizan nkoukpaizan marked this pull request as ready for review December 12, 2023 19:24
@pelesh
Copy link
Copy Markdown
Collaborator

pelesh commented Dec 12, 2023

There was a failing test on Ascent earlier. It passed when I re-ran, but that raises some flags for me.

This issue was fixed by @kswirydo in #109.

@nkoukpaizan, thanks for drawing attention to this.

Copy link
Copy Markdown
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got a couple of minor suggestions to consider, but this looks good.

Comment thread CMakeLists.txt
Comment thread CMakeLists.txt
@pelesh pelesh added enhancement New feature or request cmake labels Dec 12, 2023
Copy link
Copy Markdown
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a good idea to rebase wrt develop since the bug that is tripping KLU+Rf+FGMRES test is fixed there. It is also okay to just squash and merge imho.

@cameronrutherford
Copy link
Copy Markdown
Collaborator

@ryandanehy or @nkoukpaizan or myself should be able to add a separate Ascent testing pipeline with this new compiler configuration. Might require some small re-arch, but should be doable. Can be addressed in another PR if not immediately doable.

@pelesh
Copy link
Copy Markdown
Collaborator

pelesh commented Dec 15, 2023

@ryandanehy or @nkoukpaizan or myself should be able to add a separate Ascent testing pipeline with this new compiler configuration. Might require some small re-arch, but should be doable. Can be addressed in another PR if not immediately doable.

No need for that b/c it is getting out of service soon.

Copy link
Copy Markdown
Collaborator

@cameronrutherford cameronrutherford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - no need to test on Ascent since we are losing platform on Monday

@pelesh
Copy link
Copy Markdown
Collaborator

pelesh commented Dec 15, 2023

@nkoukpaizan, could you rebase to develop just to make sure all tests indeed pass. We can merge after that.

@nkoukpaizan nkoukpaizan force-pushed the nicholson/ascent-llvm branch from 293c367 to 4fcca01 Compare December 18, 2023 12:18
@pelesh pelesh merged commit f34b05a into develop Dec 18, 2023
@nkoukpaizan nkoukpaizan deleted the nicholson/ascent-llvm branch January 22, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmake enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build with LLVM on Ascent

3 participants