.clang-format and .pre-commit

.clang-format

@@ -0,0 +1,72 @@
+---
+Language:        Cpp
+BasedOnStyle:  Microsoft
+
+# Indentation
+IndentWidth: 2                    # 2 spaces per indent
+AccessModifierOffset: -2
+IndentAccessModifiers: false      # Align access modifiers to braces
+NamespaceIndentation: All       # Indent namspace contents
+ConstructorInitializerIndentWidth: 2
+
+# Comments which match this regex will be unformatted (and therefore can be longer or have more whitespace than other comments)
+CommentPragmas: '^\*\*'
+
+
+# Alignment
+AlignConsecutiveAssignments:
+  Enabled:          true
+  AcrossEmptyLines: false
+  AcrossComments:   true
+  AlignCompound:    true
+  PadOperators:     true
+AlignConsecutiveBitFields:
+  Enabled:          true
+  AcrossEmptyLines: false
+  AcrossComments:   true
+AlignConsecutiveDeclarations:
+  Enabled:          true
+  AcrossEmptyLines: false
+  AcrossComments:   true
+  # For future versions of clang-format
+  # AlignFunctionDeclarations: false
+  # AlignFunctionPointers: false
+AlignConsecutiveMacros:
+  Enabled:          true
+  AcrossEmptyLines: false
+  AcrossComments:   true
+
+# Newlines
+ColumnLimit:     0
+BreakBeforeBraces: Allman         # Braces on their own lines
+SeparateDefinitionBlocks: Always  # Separate definitions (functions etc.) with an empty line
+AlwaysBreakTemplateDeclarations: true # Put template on their own lines
+AllowShortBlocksOnASingleLine: Never
+# On a newer version of clang-format, replace with BinPackArguments: OnePerLine
+BinPackArguments: false           # Don't allow multiple function arguments on the same line unless they all fit
+BinPackParameters: false          # Same but for parameters
+PackConstructorInitializers: NextLine
+AllowShortFunctionsOnASingleLine: None
+BreakBeforeBinaryOperators: NonAssignment # Put binary operators after a line break, rather than before
+AllowShortIfStatementsOnASingleLine: Never
+
+# Spaces
+SpaceBeforeParens: ControlStatementsExceptControlMacros
+SpaceAfterCStyleCast: true
+PointerAlignment: Left
+
+# Includes
+IncludeBlocks: Regroup            # Regroup includes based on config
+IncludeCategories:
+  - Regex:           '(^"|\.hpp)'  # 'local' includes
+    Priority:        3
+    SortPriority:    0
+    CaseSensitive:   false
+  - Regex:           '\/'         # Library includes
+    Priority:        2
+    SortPriority:    0
+    CaseSensitive:   false
+  - Regex:           '.*'         # Everything else
+    Priority:        1
+    SortPriority:    0
+    CaseSensitive:   false

.devcontainer/devcontainer.json

@@ -30,4 +30,4 @@
 	},
     "workspaceFolder": "/home/app/",
     "workspaceMount": "source=${localWorkspaceFolder},target=/home/app/,type=bind,consistency=cached"
-}
+}

.github/ISSUE_TEMPLATE/config.yml

@@ -1 +1 @@
-blank_issues_enabled: true
+blank_issues_enabled: true

.github/pull_request_template.md

@@ -36,4 +36,3 @@
 
  _If this is a relatively large or complex change, kick off the discussion by explaining
  why you chose the solution you did and what alternatives you considered, etc._
-

.github/workflows/pre_commit.yaml

@@ -0,0 +1,22 @@
+name: resolve-bot pre-commit
+
+# Won't run on develop/main directly
+on: [pull_request]
+
+jobs:
+  pre-commit:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v3
+      with:
+        ref: ${{ github.event.pull_request.head.ref }}
+    - uses: actions/setup-python@v5.4.0
+    - uses: pre-commit/action@v3.0.1
+    - uses: EndBug/add-and-commit@v9.1.4
+      # Only need to try and commit if the action failed
+      if: failure()
+      with:
+        fetch: false
+        committer_name: GitHub Actions
+        committer_email: actions@github.com
+        message: Apply pre-commmit fixes 

.gitlab/pnnl/incline.gitlab-ci.yml

@@ -45,4 +45,4 @@ failure:
     - .report-status
   rules:
     - when: on_failure
-
+

.pre-commit-config.yaml

@@ -0,0 +1,13 @@
+repos:
+  - repo: https://github.com/pre-commit/mirrors-clang-format
+    rev: v19.1.7
+    hooks:
+    - id: clang-format
+      types_or: [c++, c, cuda]
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v5.0.0
+    hooks:
+    - id: check-toml
+    - id: forbid-new-submodules
+    - id: end-of-file-fixer
+    - id: check-yaml

CMakeLists.txt

@@ -1,6 +1,6 @@
 #[[
 
-@brief ReSolve library root
+@brief Re::Solve library root
 
 @author Slaven Peles <peless@ornl.gov>
 

CONTRIBUTING.md

@@ -185,5 +185,3 @@ class Matrix   // No, class is outside ReSolve namespace
 {
   // matrix code
 };
-
-

README.md

@@ -114,4 +114,3 @@ contributions to ReSolve must be made under the smae licensing terms.
 **Please Note** If you are using ReSolve with any third party libraries linked
 in (e.g., KLU), be sure to review the respective license of the package as that
 license may have more restrictive terms than the ReSolve license.
-

buildsystem/ascent-env.sh

@@ -2,4 +2,3 @@
 module load gcc/10.2
 # Load spack deps
 source ./buildsystem/spack/ascent/modules/dependencies.sh
-

buildsystem/incline-env.sh

@@ -12,4 +12,3 @@ unset GPU_DEVICE_ORDINAL
 
 # Load spack generated modules
 source ./buildsystem/spack/incline/modules/dependencies.sh
-

buildsystem/init-mirror.sh

@@ -15,4 +15,3 @@ res=$?
 chmod -R ugo+wrx $SPACK_MIRROR &
 
 exit $res
-

buildsystem/spack/ascent/env.sh

@@ -21,4 +21,3 @@ export SPACK_PYTHON=$(which python)
 export tempdir=$SPACK_CACHE
 export TMP=$SPACK_CACHE
 export TMPDIR=$SPACK_CACHE
-

buildsystem/spack/ascent/spack.yaml

@@ -65,4 +65,3 @@ spack:
       modules: [gcc/10.2]
       operating_system: rhel8
       target: ppc64le
-

buildsystem/spack/deception/spack.yaml

@@ -57,4 +57,4 @@ spack:
         fc: /share/apps/gcc/9.1.0/bin/gfortran
       operating_system: centos7
       target: x86_64
-      modules: [gcc/9.1.0]
+      modules: [gcc/9.1.0]

buildsystem/spack/incline/env.sh

@@ -24,4 +24,3 @@ export SPACK_PYTHON=$(which python3)
 export tempdir=$SPACK_CACHE
 export TMP=$SPACK_CACHE
 export TMPDIR=$SPACK_CACHE
-

cmake/ReSolveFindHipLibraries.cmake

@@ -34,4 +34,3 @@ target_include_directories(resolve_hip INTERFACE
   $<BUILD_INTERFACE:${hip_includes}>)
 
 install(TARGETS resolve_hip EXPORT ReSolveTargets)
-

docs/doxygen/doxygen-awesome-interactive-toc.js

@@ -78,4 +78,4 @@ class DoxygenAwesomeInteractiveToc {
         active?.classList.add("active")
         active?.classList.remove("aboveActive")
     }
-}
+}

docs/doxygen/doxygen-awesome-tabs.js

@@ -67,4 +67,4 @@ class DoxygenAwesomeTabs {
             })
         })
     }
-}
+}

docs/doxygen/index.rst

@@ -4,4 +4,3 @@ API Documentation
 
 
 Doxygen generated API documentation can be found here: `Doxygen Docs <html/index.html>`_
-

docs/requirements.txt

@@ -2,4 +2,4 @@ docutils
 sphinx==6.2.1
 sphinx-rtd-theme==1.2.2
 breathe 
-m2r2
+m2r2

docs/sphinx/license.rst

@@ -2,4 +2,4 @@
 License
 *******
 
-.. include:: ../../LICENSE
+.. include:: ../../LICENSE

docs/sphinx/style/theme_overrides.css

@@ -19,4 +19,4 @@
  /* Sidebar header (and topbar for mobile) */
  .wy-side-nav-search, .wy-nav-top {
    background: #343131;
- }
+ }