Added methods to diagonally scale csr matrices on the left and right.#281
Closed
shakedregev wants to merge 8 commits intodevelopfrom
Closed
Added methods to diagonally scale csr matrices on the left and right.#281shakedregev wants to merge 8 commits intodevelopfrom
shakedregev wants to merge 8 commits intodevelopfrom
Conversation
877bb7c to
694a59a
Compare
Collaborator
Author
|
A clarification: The different order of arguments for |
9 tasks
Collaborator
Author
|
Closing this as it is broken. Replaced by #283. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is necessary to solve the issue of L and U being in the right format. See details here. Additionally, diagonal scaling is needed for SUNDIALS and HyKKT integration.
1 of the 2 steps necessary to close issue 251
Mentions @(user)
Proposed changes
I added methods to diagonally scale CSR matrices on the left and right. This will allow the use of external codes and moving the unit diagonal when we transpose and switch L and U by interpreting their CSC representation as CSR. New unit tests pass.
Checklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here
to help! This is simply a reminder of what we are going to look for before
merging your code.
-Wall -Wpedantic -Wconversion -Wextra.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining
why you chose the solution you did and what alternatives you considered, etc.