Fixed double allocations and added assert statements#293
Merged
Conversation
pelesh
approved these changes
Jun 4, 2025
Collaborator
pelesh
left a comment
There was a problem hiding this comment.
Build and installation tests pass, straightforward fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Error messages are returned when running GMRES tests suggesting the solver is trying to access GPU memory. These are benign messages as computation is carried out to completion on a CPU device and all GPU calls are ignored, but the code should not be trying to access the the device memory in the CPU mode in the first place.
_Closes #286 _
@pelesh
Proposed changes
My changes enforce strict checks on owning gpu data and remove double allocations.
Checklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here
to help! This is simply a reminder of what we are going to look for before
merging your code.
-Wall -Wpedantic -Wconversion -Wextra.The rebase was required to get tests passing.