Unit testing for Sparse matrix class#294
Merged
shakedregev merged 16 commits intodevelopfrom Jun 5, 2025
Merged
Conversation
shakedregev
reviewed
Jun 2, 2025
shakedregev
reviewed
Jun 2, 2025
shakedregev
reviewed
Jun 2, 2025
shakedregev
requested changes
Jun 2, 2025
Collaborator
shakedregev
left a comment
There was a problem hiding this comment.
Tests are spuriously passing on Frontier (likely due to some pointer comparison that happens to be true). They are failing on CUDA, almost certainly because of the code I pointed out (and other places where it's repeated).
shakedregev
reviewed
Jun 2, 2025
pelesh
requested changes
Jun 3, 2025
Collaborator
pelesh
left a comment
There was a problem hiding this comment.
This is a good start but requires some more work. Setting this as a draft.
Collaborator
|
There is a minor warning that needs fixing: |
009cbde to
ade6772
Compare
a40e456 to
12f6c7e
Compare
pelesh
reviewed
Jun 5, 2025
8cede43 to
bc4d3c4
Compare
shakedregev
reviewed
Jun 5, 2025
Collaborator
shakedregev
left a comment
There was a problem hiding this comment.
Looks good and tests pass. Just add tests for rectangular matrices and let's make sure they still pass.
shakedregev
approved these changes
Jun 5, 2025
Collaborator
shakedregev
left a comment
There was a problem hiding this comment.
Tests pass and all comments addressed. Approving
pelesh
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements unit testing for
Sparse.cpp.Closes #280
Proposed changes
Tests implemented:
Checklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here
to help! This is simply a reminder of what we are going to look for before
merging your code.
-Wall -Wpedantic -Wconversion -Wextra.Further comments