Kernels for scaling a vector by a diagonal matrix#300
Merged
shakedregev merged 4 commits intodevelopfrom Jun 5, 2025
Merged
Conversation
shakedregev
approved these changes
Jun 5, 2025
Collaborator
shakedregev
left a comment
There was a problem hiding this comment.
Looks good and tests pass. Adding just one small clarification and merging.
Collaborator
|
Clarification: this also implements CPU kernels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements HIP and CUDA kernels to scale vectors by diagonal matrices (element-wise product).
Closes #280
Proposed changes
Implements the kernels and a test that scales the incrementing vector of length
nby itself.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments