-
Notifications
You must be signed in to change notification settings - Fork 9
Updated changelog and PR template #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| # Re::Solve Changelog | ||
|
|
||
| ## Changes to Re::Solve in release 0.99.2 | ||
|
|
||
| ### Major Features | ||
|
|
||
| 1. Re::Solve now works reliably with asymmetric matrices, with no need for intermediate CSC storage. | ||
| This requires switching $L$ with $U$ and $P$ with $Q$ and reinterpretting them as CSR instead of CSC. | ||
| It is seamless from the user perspective and fixed many bugs. | ||
|
|
||
| 2. Added more rigorous checks for PRs for clang formatting and to compile without warnings and memory leaks. | ||
|
|
||
| 3. Updated pull request and issue templates. | ||
|
|
||
| ### Bug Fixes | ||
|
|
||
| 1. Fixed a bug that produced inaccurate results for some asymmetric matrices with major feature 1. | ||
|
|
||
| 2. Synchronized devices after HIP functions. HIP executes asynchronously, so bugs occured wihout synchronization. | ||
|
|
||
| 3. Corrected the way cmake finds suitsparse. | ||
|
|
||
| 4. Fixed various memory leaks and compiler warnings. | ||
|
|
||
| ### Minor Features and Enhancements | ||
|
|
||
| 1. Changed all examples and tests to use Csr format, added uniform command line parsers (no longer hard-coded), and decluttered them. | ||
|
|
||
| 2. Added asymmetric matrices and well-conditioned matrices to the test suite. | ||
|
|
||
| 3. Removed RocSparse "fast mode" triangular solver and use RocSolver triangular solver only as it is now faster and removes dependencies. | ||
|
|
||
| 4. Put sorting inside the KLU extraction because many solvers assume sorted factors and there's no need to reimplement sorting constantly. | ||
|
|
||
| 5. Removed duplicate code, added code comments, corrected code to fit guidelines, removed magic numbers, and simplified code where possible. | ||
|
|
||
| 6. Added the ability to reset a workspace without completely destroying it. | ||
|
|
||
| 7. Improved testing and added tests where they were missing. | ||
|
|
||
| 8. Added kernels for multiplying a vector by a diagonal matrix and a general matrix by a diagonal matrix (left and right). | ||
|
|
||
| 9. Prohibitted sloppy memory syncing and added more descriptive error messages when a prohibited action is attempted. | ||
|
|
||
| 10. The code now tracks the updated status for each vector in a multivector. | ||
|
|
||
| 11. Added the ability to reuse a transpose allocation. | ||
|
|
||
| 12. Added the ability to generically set solver parameters. | ||
|
|
||
| 13. Added LUSOL direct solver, which can factorize matrices and extract factors independently of KLU. | ||
|
|
||
| 14. Various Spack updates. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.