Skip to content

Fixed floating point and constant usage#419

Merged
pelesh merged 3 commits intodevelopfrom
shaked/float_doc
Mar 18, 2026
Merged

Fixed floating point and constant usage#419
pelesh merged 3 commits intodevelopfrom
shaked/float_doc

Conversation

@shakedregev
Copy link
Copy Markdown
Collaborator

@shakedregev shakedregev commented Mar 17, 2026

Description

There was no clear convention for writing floating point numbers which resulted in code inconsistencies.

Proposed changes

I changed the conventions and resolved the inconsistencies.

Checklist

  • All tests pass (make test and make test_install per testing instructions). Code tested on
    • CPU backend
    • CUDA backend
    • HIP backend
  • I have manually run the non-experimental examples and verified that residuals are close to machine precision. (In your build directory run: ./examples/<your_example>.exe -h to get instructions how to run examples). Code tested on:
    • CPU backend
    • CUDA backend
    • HIP backend
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows Re::Solve style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

@shakedregev shakedregev requested a review from pelesh March 17, 2026 17:53
@pelesh pelesh force-pushed the shaked/float_doc branch from 3f7bcd5 to 6e1e814 Compare March 18, 2026 01:30
Copy link
Copy Markdown
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pelesh pelesh merged commit 82b1cb0 into develop Mar 18, 2026
6 checks passed
@shakedregev shakedregev deleted the shaked/float_doc branch March 18, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants