Skip to content

Conversation

@chikle9090
Copy link
Contributor

This PR addresses issue #3902 by expanding the documentation for +proj=affine.

Summary of changes

  • Clearly documents that affine input angular values are interpreted in radians.
  • Clearly documents that affine output angular values are expressed in degrees.
  • Adds explanation that proj +proj=affine cannot be used directly and will raise an error.
  • Shows that affine must be used as a step in a pipeline.
  • Adds examples demonstrating real behavior (such as the cs2cs example from issue Mention affine units #3902).
  • Adds recommendations for correct usage when working with geographic vs projected coordinates.

Checklist

  • Closes Mention affine units #3902
  • Tests added (Not applicable: documentation-only change)
  • Added a clear title that can be used to generate release notes
  • Fully documented (updated affine.rst accordingly)

@chikle9090 chikle9090 mentioned this pull request Dec 3, 2025
@hobu
Copy link
Contributor

hobu commented Dec 3, 2025

Is this LLM-generated code? I don't understand these changes or why they're grouped together the way they are.

The CMake changes should be their own PR if they're actually needed.

The install doc change is incorrect.

@chikle9090 chikle9090 closed this Dec 3, 2025
@chikle9090 chikle9090 reopened this Dec 3, 2025
@chikle9090 chikle9090 closed this Dec 3, 2025
@chikle9090
Copy link
Contributor Author

Closing this PR because it included unrelated commits.
I have opened a new clean PR with only the intended affine.rst documentation changes for #3902.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mention affine units

2 participants