PROJ_INCLUDE_DIR not leveraged at compile time by CMake

[jmckenna]

• using libgeotiff 1.7.4 & master
• compiler is Visual Studio on Windows
• CMake version 4.0.2
• today's PROJ master
• usual build process fails with Cannot open include file: 'proj.h': No such file or directory
  • -DPROJ_INCLUDE_DIR is passed to CMake as usual, so something seems to have changed in the source of libgeotiff, or CMake itself
  • all is well with libgeotiff 1.7.3 & previous releases
• possibly related to CMake changes made through Automate release generation from tags and refactor CI #115
• workaround: add the following to /CMakeLists.txt around line#114

IF(PROJ_FOUND)
  INCLUDE_DIRECTORIES(${PROJ_INCLUDE_DIR})
ENDIF()

[hobu]

I wonder what is different about your windows build configuration. The libgeotiff one is now quite boring https://github.com/OSGeo/libgeotiff/blob/master/.github/workflows/test.yml

Can you configure/compile in verbose mode? What does the CMake output look like in regards to finding PROJ? Which version of PROJ?

Also, what's the compilation line that's being generated when it goes to compile? PROJ is a required dependency, so it must be found, but something is up with the definition of the PROJ target and libgeotiff's usage of it.

[jmckenna]

@hobu this is with today's PROJ master.

Here is the compile error:

[ 92%] Building C object bin/CMakeFiles/geotifcp.dir/geotifcp.c.obj
geotifcp.c
libgeotiff\geo_keyp.h(18): fatal error C1083: Cannot open include file: 'proj.h': No such file or directory

Regarding what is different with my setup, I notice most others have one single directory containing all include files for all libraries, inside that directory, so it avoids the use of the *_INCLUDE_DIR at compile time.

[jmckenna]

I notice this line in my CMake logs:

-- Found PROJ: proj-git-master/build/install/lib/proj.lib (found version "9.7.0")

[rouault]

@jmckenna #138 should fix your issue

[jmckenna]

thanks @rouault I confirmed your fix here. Thanks to both of you!