Add method create_build_target_dir #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schaefi
force-pushed
the
check_target_dir_permissions
branch
from
0b4d419 to
f862ca9
Compare
dcermak
reviewed
Jun 26, 2025
dcermak
left a comment
dcermak
left a comment
There was a problem hiding this comment.
LGTM overall, but how will this look in practice if the dir is not writable? Is the error legible for the user?
Contributor
Author
It will look like this for example I believe this tells you all you need, no ? |
The new method creates the given --target-dir if not yet present and checks if the calling user can touch the result log file prior starting the build process
As documented in https://setuptools.pypa.io/en/latest/pkg_resources.html the use of pkg_resources is obsolete and will cause issues. So happened on Debian unstable.
schaefi
force-pushed
the
check_target_dir_permissions
branch
from
15a2e61 to
148e624
Compare
Yes it does 👍 |
dcermak
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new method creates the given --target-dir if not yet present and checks if the calling user can touch the result log file prior starting the build process