`set btrfs_relative_path="y"` is set unconditionally

[supakeen]

It seems kiwi unconditionally writes the set btrfs_relative_path="y" in

kiwi/kiwi/bootloader/config/grub2.py

Line 1246 in 24e884d

early_boot.write(

(and some other places).

While I don't think it's actively harmful it's also only used when changing default subvolumes; for example in boot-to-snapshot scenarios. Currently this is being written on the Fedora 44 Cloud images even though no snapshotting features are enabled there.

[Conan-Kudo]

This probably should be controlled by the btrfs_set_default_subvolume flag, I think? Since that's where this matters.

[Conan-Kudo]

Related ticket: #1931

[schaefi]

Hmm, I'm leaning towards removing this variable from the early boot script. Let me explain. The early boot script is a blob script that gets included into the EFI binary image if kiwi see's the need to build its own EFI binary image. This condition should actually never be met for main/standard/released distributions which all provides a pre-built EFI binary which kiwi searches for at several places and then just use the one from the distro.

As such the early boot script is usually only effective for extra or intermediate media like install ISO, or live ISO images and there the setting doesn't make any sense because those are not using btrfs.

I believe this setting is in 99% of all cases pointless and I vote for simply dropping it

Thoughts ?

[Conan-Kudo]

It is possible to use btrfs in those cases, though. At least dracut supports it, and if we don't now, we probably will eventually.

It also exists in our grub2 config template:

kiwi/kiwi/bootloader/template/grub2.py

Lines 30 to 31 in 24e884d

	set btrfs_relative_path="y"
	export btrfs_relative_path