Skip to content

Conversation

@grahamhelton
Copy link

Description

I cannot believe I am submitting a PR this small but considering this is a learning utility and those running it may not be familiar with Linux/docker

  • Added sudo to the readme instructions
  • There was a bug where the "–" character was being used instead of "--" which caused docker-compose -f docker-compose.yml --compatibility down --volumes to not work as intended.

Before with docker-compose -f docker-compose.yml --compatibility down –volumes:
image

After with sudo docker-compose -f docker-compose.yml --compatibility down --volumes:
image

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested the service locally.

Documentation

Make sure that you have documented corresponding changes in this repository.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged
  • I have documented any changes if required in the docs.

@piyushroshan
Copy link
Collaborator

Closing in favor of #257 as sudo is not compatible with all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants