Migrate solution to the slnx format#507
Conversation
WalkthroughReplaces the legacy Visual Studio solution file Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@Obsidian.slnx`:
- Around line 1-11: The .slnx change is good but you must surface the minimum
tooling requirements mentioned in the review: add a clear note (e.g., in README
or CONTRIBUTING) stating that the .slnx format requires Visual Studio 2022
17.13+ or .NET SDK 9.0.200+ so contributors know how to open the Solution
element and included Project entries (Obsidian.API, Obsidian.ConsoleApp,
Obsidian.Nbt, Obsidian.SourceGenerators, Obsidian.Tests, Obsidian). Update the
repository documentation and/or CI checks to validate the required SDK/VS
versions.
Could you please approve this workflow? |
For some reason the build workflow isn't running but shouldn't be a problem, I'll merge in a sec |
It's much more readable and helps to avoid potential merge conflicts.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.