Skip to content

Migrate solution to the slnx format#507

Merged
Tides merged 2 commits intoObsidianMC:1.21.xfrom
acopier:slnx
Jan 19, 2026
Merged

Migrate solution to the slnx format#507
Tides merged 2 commits intoObsidianMC:1.21.xfrom
acopier:slnx

Conversation

@acopier
Copy link
Contributor

@acopier acopier commented Jan 17, 2026

It's much more readable and helps to avoid potential merge conflicts.

Summary by CodeRabbit

  • Chores
    • Replaced the legacy solution file with a new solution descriptor that re-establishes the workspace and project listings.
    • Updated project configuration metadata to improve IDE and tooling compatibility across the repository.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 17, 2026

Walkthrough

Replaces the legacy Visual Studio solution file Obsidian.sln with a new Obsidian.slnx solution descriptor; project references and solution items are preserved and no public API or runtime logic is changed. (45 words)

Changes

Cohort / File(s) Summary
Solution Format Migration
Obsidian.sln, Obsidian.slnx
Removed legacy .sln (≈60 lines) and added .slnx (≈11 lines) that lists the same six projects and solution items; no code, API, or build logic changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 I hopped through files both old and new,
Swapped .sln for .slnx with a joyful chew,
Six projects snug in a tidy line,
Build's the same — but oh, how fine! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Migrate solution to the slnx format' accurately describes the main change: replacing Obsidian.sln with Obsidian.slnx.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@Obsidian.slnx`:
- Around line 1-11: The .slnx change is good but you must surface the minimum
tooling requirements mentioned in the review: add a clear note (e.g., in README
or CONTRIBUTING) stating that the .slnx format requires Visual Studio 2022
17.13+ or .NET SDK 9.0.200+ so contributors know how to open the Solution
element and included Project entries (Obsidian.API, Obsidian.ConsoleApp,
Obsidian.Nbt, Obsidian.SourceGenerators, Obsidian.Tests, Obsidian). Update the
repository documentation and/or CI checks to validate the required SDK/VS
versions.

Copy link
Member

@Tides Tides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acopier
Copy link
Contributor Author

acopier commented Jan 18, 2026

LGTM

Could you please approve this workflow?

@Tides
Copy link
Member

Tides commented Jan 18, 2026

LGTM

Could you please approve this workflow?

For some reason the build workflow isn't running but shouldn't be a problem, I'll merge in a sec

@Tides Tides merged commit c9a076f into ObsidianMC:1.21.x Jan 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants