Aux Data Cleaner logging bugfix#69
Open
ljones37oet wants to merge 18 commits intoOceanDataTools:2.xfrom
Open
Conversation
Adds the ability to control the visibility of event options based on the values of other event options. This allows administrators to create more dynamic and context-aware event templates, improving the user experience and reducing the likelihood of errors.
Updates the API key route paths to use snake_case instead of kebab-case for consistency. This change ensures that the API adheres to a consistent naming convention for route paths.
…x and Coriolix implementations Note: initial refactor was done by CoPilot and then edited by me
insert_aux_data_from_ws now runs one connection session and raises exceptions cleanly on disconnect The outer loop in run_aux_data_inserter is now the sole responsibility for retry logic. inner loop = "listen for events", outer loop = "reconnect on failure"
…t all inserters need a query
Instead of directly interacting with the eventAuxDataTable, the events API endpoints now publish deleteEvents messages, which the aux_data_managers are listening for. When an aux_data_manager receives a deleteEvents messages, it sends the contents to its aux_data_file_cleaner(s) which do any external clean up required and then send a delete request to the API event_aux_data endpoint # Conflicts: # routes/api/v1/events.js
…en you delete framegrab aux data, it will also delete the images from the sealog files Note: we do not use framegrab, so I didn't have a great way to test this, but it is very similar to our stillcap_ffmpeg aux data mgr, which I have tested extensively
Aux data inserters-->aux data managers
…here's no aux data while debugging
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 27597708 | Triggered | Generic Password | 39e661f | test/api_keys.test.js | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I forgot to make data source a public property on the cleaner. It caused a crash during some debug logging in the aux_data_manager_runner.