Write push result output variables#1765
Merged
eddymoulton merged 11 commits intomainfrom Feb 13, 2026
Merged
Conversation
eddymoulton
reviewed
Feb 10, 2026
Contributor
eddymoulton
left a comment
There was a problem hiding this comment.
Approach seems fine to me 🤷
# Conflicts: # source/Calamari/ArgoCD/Conventions/UpdateArgoCDAppImagesInstallConvention.cs # source/Calamari/ArgoCD/Conventions/UpdateArgoCDApplicationManifestsInstallConvention.cs
flin-8
reviewed
Feb 13, 2026
| } | ||
|
|
||
|
|
||
| var result = new PushResult(commit.Sha, commit.ShortSha()); |
Contributor
There was a problem hiding this comment.
nit: It would be clearer if we just short circuited and returned the push result here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates output variables to correctly track commited changes for each application and source.
We're tracking:
These values will be used for subsequent operations, such as:
Example result for a direct commit
Multi-source direct commit
Pull request
Note: There is currently a known issue where multiple ArgoCD applications with the exact same source and using the direct commit method will not have this data reported. This is not addressed in this PR.
(PR taken over by @eddymoulton)
Closes MD-1514