-
Notifications
You must be signed in to change notification settings - Fork 154
params: Add initial L1 base fee to configuration #603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
bragaigor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6873b33
bragaigor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
|
||
| // GetInitialL1BaseFee returns the initial L1 base fee for the ArbOS instance. | ||
| // If not set, it returns the default value. | ||
| func (a *ArbOSInit) GetInitialL1BaseFee() *big.Int { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I arrived at this comment while thinking about how to handle serialized chain config here.
If serialized chain config is provided in ArbOSInit then it will not be possible to have a ArbOSInit.GetSerializedChainConfig that would return a default value, since ArbOSInit doesn't have access to a default chain config.
core.Genesis, that has the ArbOSInit field, has a ChainConfig field that could be used to compute a default serialized chain config.
Nitro allows the core.Genesis.ChainConfig, from genesis JSON file, to be updated BTW, so that is an extra complication.
That said, ArbOSInit will likely not be the best place to retrieve the default InitialL1BaseFee.
This decision is quite coupled with the decision on how serialized chain config will be provided, so ideally they must be done in a single PR.
WDYT?
We can discuss this better in a meeting.
DefaultInitialL1BaseFeefromnitro/arbostypes.ArbOSInitfield) by theInitialL1BaseFee.DefaultInitialL1BaseFee) toArbOSInitfor best-effort backwards compatibility with oldgenesis.jsonfiles.pulled in by OffchainLabs/nitro#4171