Skip to content

Conversation

@amsanghi
Copy link
Contributor

@amsanghi amsanghi commented Aug 5, 2025

Fixes: NIT-3652

Ensures that blob prices are only used when the parent chain supports them.

Even if the config expected-surplus-gas-price-mode is set to BlobPrice, we now check whether the parent chain supports blobs by verifying that both header.BlobGasUsed and header.ExcessBlobGas are non-nil.

If either of these fields is nil (indicating lack of blob support), the logic falls back to the calldata price model.

This prevents incorrect behavior on chains that do not support EIP-4844.

@amsanghi amsanghi marked this pull request as ready for review August 5, 2025 14:51
@amsanghi amsanghi requested a review from eljobe August 5, 2025 14:51
@codecov
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 22.62%. Comparing base (7c81586) to head (68a1d20).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3450      +/-   ##
==========================================
+ Coverage   22.59%   22.62%   +0.02%     
==========================================
  Files         383      383              
  Lines       58047    58047              
==========================================
+ Hits        13118    13134      +16     
+ Misses      42905    42888      -17     
- Partials     2024     2025       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amsanghi amsanghi requested a review from joshuacolvin0 August 5, 2025 16:07
@amsanghi amsanghi assigned joshuacolvin0 and unassigned eljobe Aug 5, 2025
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 enabled auto-merge August 5, 2025 17:17
@joshuacolvin0 joshuacolvin0 merged commit 39c4895 into master Aug 5, 2025
21 of 22 checks passed
@joshuacolvin0 joshuacolvin0 deleted the auto_switch_to_calldata branch August 5, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants