Skip to content

Conversation

@asachin96
Copy link

No description provided.

@TCourtneyOwen
Copy link
Contributor

Any ideas what's causing the log test to fail?

@asachin96
Copy link
Author

Any ideas what's causing the log test to fail?

There's a bug in Console redirection, which is I fixed in PR microsoft/react-native-windows#2624. I'm removing type check till that gets merged to devmain

@asachin96 asachin96 requested a review from akrantz June 19, 2019 23:21
Copy link
Contributor

@akrantz akrantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@TCourtneyOwen Let's sync up tomorrow if we want to merge this yet or not, given the desire to update generator-office.

Also, if port 9229 is already in use, what happens when the test is run?

@akrantz
Copy link
Contributor

akrantz commented Jun 20, 2019

Sachin, you can merge the latest changes from the master branch. We'll wait to merge this PR until we've completed the Yo Office release.

@asachin96
Copy link
Author

See comments.

@TCourtneyOwen Let's sync up tomorrow if we want to merge this yet or not, given the desire to update generator-office.

Also, if port 9229 is already in use, what happens when the test is run?

WebSocket will retry for 10 times to open if it doesn't succeed, nothing happens, but tests will fail because there will no events to validate

@lindalu-MSFT
Copy link
Member

What is the status of this PR? Can it be closed?

@akrantz akrantz closed this Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants