-
Notifications
You must be signed in to change notification settings - Fork 64
Console log protocol tests #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Any ideas what's causing the log test to fail? |
There's a bug in Console redirection, which is I fixed in PR microsoft/react-native-windows#2624. I'm removing type check till that gets merged to devmain |
akrantz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
@TCourtneyOwen Let's sync up tomorrow if we want to merge this yet or not, given the desire to update generator-office.
Also, if port 9229 is already in use, what happens when the test is run?
|
Sachin, you can merge the latest changes from the master branch. We'll wait to merge this PR until we've completed the Yo Office release. |
WebSocket will retry for 10 times to open if it doesn't succeed, nothing happens, but tests will fail because there will no events to validate |
|
What is the status of this PR? Can it be closed? |
No description provided.