This repository was archived by the owner on Feb 4, 2022. It is now read-only.
Feature/username regex #717
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@lifenautjoe I could need some help with the failing build, since the error does not really provide me some insight what's causing the fail. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the username RegEx to follow the criteria from #228 .
Thanks @Komposten who improved my RegEx drafts.
I'm not sure if there has to be some update routines to change current usernames with not allowed chars? But that could have sideeffects on the login that needs the username...
This PR is related to the old open PR #368, but I didn't know how this one could be updated.