Global object should be equal to the parent object.#46
Global object should be equal to the parent object.#46Olical merged 3 commits intoOlical:developfrom nathggns:global_object
Conversation
|
I was always under the impression that the scope would just follow through magically, I probably should have investigated this a while ago. I guess people could always have used I'll have a poke around with this soon and probably merge it in as soon as I'm sure it's okay and I have it documented. Thank you for adding tests too! It would be interesting to see if this would break any current code, although I highly doubt it. Thanks a lot for the improvements. |
|
Any reason why this was closed? This seemed useful. |
|
Oh, don't worry, it has been merged in. I should of put a comment in here, my bad. It was commited to master and I merged it into develop, I also merged it with the wrong argument and didn't realise. So GitHub can't see it, but it was merged in. |
Inside event handlers, the global object (
this), should be equal to the object the event is being triggered on.This fixes that, and adds a test for it.