Amalesh taking over for Jay - Toggle Request Bio Permission by Alforoan · Pull Request #704 · OneCommunityGlobal/HGNRest

Alforoan · 2024-01-14T19:16:34Z

Description

A user with a 'requestBio' permission is now able to toggle the bio switch under Weekly Summaries Report.

Related PRS (if any):

To test this backend PR you need to checkout the #1831 frontend PR.
…

Main changes explained:

Add controller logic so that once the user with the requestBio permission toggles the switch under Weekly Summaries Report, the change is saved properly.
…

How to test:

check into current branch
do npm install, npm run build and npm run start to run this PR locally
Clear site data/cache

nathanah · 2024-01-27T00:11:50Z

src/controllers/userProfileController.js

+    const isRequestorAuthorized = (!!(
      canRequestorUpdateUser(req.body.requestor.requestorId, userid) && (
-        await hasPermission(req.body.requestor, 'putUserProfile')
+        await hasPermission(req.body.requestor, 'putUserProfile')) || await hasPermission(req.body.requestor, 'requestBio')


This makes the requestBio permission also able to modify the rest of users' profiles, not just the bioRequested field.

Renanluizssx

see my regiew @Alforoan please in PR#1831:OneCommunityGlobal/HighestGoodNetworkApp#1831

Pandani07

Got an error when testing this PR, posted a review on the frontend PR

galgalinidhi · 2024-02-11T05:11:23Z

Hi @Alforoan, I left a comment here- OneCommunityGlobal/HighestGoodNetworkApp#1831

mohabbasd

Hello, I tested your PR but it is not working as expected.

XiaohanMeng

Hi, I left my review on the FE project: OneCommunityGlobal/HighestGoodNetworkApp#1831

skaush21 · 2024-02-21T02:53:39Z

see review on the frontend PR: OneCommunityGlobal/HighestGoodNetworkApp#1831

Jingyii800

Hi, while trying to test this feature, I encountered a bug on this backend. Please check in this comment. OneCommunityGlobal/HighestGoodNetworkApp#1831 (review)

chrischenlixing

Check out frontend comment

MALAV1308

Hello, I got an error while reviewing your PR. Please refer this link. OneCommunityGlobal/HighestGoodNetworkApp#1831 (review)

src/controllers/userProfileController.js

brandta-1

Review

see front-end review.

Co-authored-by: Nathan Hoffman <nathanahoffman@gmail.com>

DiegoSalas27 · 2024-03-10T02:54:14Z

Hi Jay,

I have been trying to run the backend but I am not able to do that. I get an error that breaks the backend project and it nevers runs. I have attached a video showcasing it.

Screen.Recording.2024-03-09.at.9.50.21.PM.mov

rajnada · 2024-03-19T23:35:25Z

Hii,

I am getting the Error after pulling this current branch.

hetvi11110

I am also encountering the same error when running the npm run build command. It seems to be a syntax error. Here is a reference screenshot.

iven-yao

unable to build, following is the error message:

Coops023

Hi, i got an error while trying to run the backend locally, find a screenshot attached.

Tiantian-C

Hi,
I tried to run the backend code, but I came across some errors when I ran it.

SRamen1999

When running this backend PR I am encountering an error when running the npm run build command.

Gayathr-2012 · 2024-03-27T23:13:13Z

Hi
I checked out your branch and encountered an error. It appears there's a missing closing parenthesis. Please ensure the user profiles section is correctly closed. This PR has issue.

kylepham

There is a redundant open curly bracket in this PR. Removing it allows the code to build and run. There are also some variables being declared but not used.

src/controllers/userProfileController.js

kylepham · 2024-04-02T21:10:25Z

src/controllers/userProfileController.js

    );

-    if (!isRequestorAuthorized) {
+    const canEditTeamCode = req.body.requestor.role === 'Owner'


This variable is declared but not used?

Kavil-Jain-514

Facing errors when building the application
Steps: Checkout to the branch -> npm install -> npm run build
Error:

nyelmela

I am encountering an issue when attempting to build the current branch. After performing npm install, running npm run build results in a BABEL_PARSE_ERROR related to an unexpected token in userProfileController.js at line 1052. I've attached the error screenshot.

Shadhrush5

Hi, I reviewed the PR #704. Seems like I ran into an issue while building the current branch. I have attached a screenshot as well.

souravwalke · 2024-08-04T04:26:40Z

I tried reviewing the PR but was unable to deploy and got the following error on running the npm run build.

swaroop-2007

Hi, I tried reviewing this PR but am experiencing problems while starting the server.
Please refer to the screenshot below:

crystallow1168 · 2024-09-14T05:30:15Z

@Alforoan,

I am having issues starting the backend's server. Refer to the image for the errors.
The steps I did:

I'm on node v14.17.6
npm install -> npm run build -> run into errors

nishitag5

After checking out these changes and running npm build command, I am getting the below error:

neeharikakoniki

Unable to build run

Muzammil603

Its not working

mrinalini-raghavendran19

Hello!

The PR works mostly as expected - attached below is a recording of the same working.

I was able to login as an Owner and assign Toggle Request Bio permission to a volunteer user.

By logging in as a volunteer I was able to navigate to the Reports page -> weekly summaries section and use the toggle bar as expected.

Screen.Recording.2024-10-01.at.1.28.25.PM.mov

I do however have a few suggestions -

When I check into the backend branch, I face issues at build time. More specifically from the userProfileController.js.

There seems to be a redundant { in the code (snippet attached below for reference to anyone else facing the same issue):

if (!isRequestorAuthorized && !canToggleRequestBio) { // remove this brace { res.status(403).send('You are not authorized to update this user'); return; }

Great work!

Supriya1659

Got an error while testing this PR

Deekshith010905 · 2025-07-09T18:03:40Z

The dashboard page loaded, but multiple “Unexpected error” messages were displayed, and some values such as "Current Week" and "HGN Totals" showed as NaN or undefined. This suggests that required data is either not loading properly from the backend or is being parsed incorrectly on the frontend.

add controller logic

be81044

This was referenced Jan 14, 2024

Amalesh taking over for Jay - PERMISSION: Toggle Request Bio Permission OneCommunityGlobal/HighestGoodNetworkApp#1831

Closed

Anirudh SK finishing for Jay - PERMISSION: Modify Task X on Dashboard Permission OneCommunityGlobal/HighestGoodNetworkApp#1850

Merged

nathanah requested changes Jan 27, 2024

View reviewed changes

add conditional logic

edbae79

Renanluizssx reviewed Feb 1, 2024

View reviewed changes

Pandani07 suggested changes Feb 10, 2024

View reviewed changes

mohabbasd suggested changes Feb 12, 2024

View reviewed changes

XiaohanMeng self-requested a review February 15, 2024 22:20

XiaohanMeng suggested changes Feb 15, 2024

View reviewed changes

Jingyii800 suggested changes Feb 23, 2024

View reviewed changes

chrischenlixing approved these changes Feb 24, 2024

View reviewed changes

Merge branch 'development' into Jay_Toggle_Request_Bio_BackEnd

535ea3d

MALAV1308 suggested changes Mar 2, 2024

View reviewed changes

nathanah requested changes Mar 2, 2024

View reviewed changes

src/controllers/userProfileController.js Outdated Show resolved Hide resolved

brandta-1 suggested changes Mar 3, 2024

View reviewed changes

Update src/controllers/userProfileController.js

9285ffc

Co-authored-by: Nathan Hoffman <nathanahoffman@gmail.com>

hetvi11110 suggested changes Mar 21, 2024

View reviewed changes

iven-yao suggested changes Mar 22, 2024

View reviewed changes

Coops023 suggested changes Mar 22, 2024

View reviewed changes

Tiantian-C reviewed Mar 25, 2024

View reviewed changes

SRamen1999 suggested changes Mar 27, 2024

View reviewed changes

kylepham suggested changes Apr 2, 2024

View reviewed changes

Kavil-Jain-514 suggested changes Jun 6, 2024

View reviewed changes

nyelmela reviewed Jul 13, 2024

View reviewed changes

Shadhrush5 suggested changes Jul 26, 2024

View reviewed changes

swaroop-2007 suggested changes Sep 13, 2024

View reviewed changes

nishitag5 self-requested a review September 15, 2024 05:18

nishitag5 suggested changes Sep 15, 2024

View reviewed changes

neeharikakoniki suggested changes Sep 20, 2024

View reviewed changes

Muzammil603 approved these changes Sep 21, 2024

View reviewed changes

mrinalini-raghavendran19 suggested changes Oct 1, 2024

View reviewed changes

Supriya1659 suggested changes Nov 9, 2024

View reviewed changes

Amalesh-A added 3 commits August 14, 2025 19:48

PR reworked

ed19a3a

Merge Conflicts Resolved

8a54045

Merge Conflicts Resolved

429b06e

one-community changed the title ~~Jay - Toggle Request Bio Permission~~ Amalesh taking over for Jay - Toggle Request Bio Permission Oct 19, 2025

one-community closed this Oct 25, 2025

This was referenced Jan 8, 2026

Amalesh - Toggle Request Bio permission on Weekly Summaries Report #1990

Merged

Amalesh - Toggle Request Bio permission on Weekly Summaries Report OneCommunityGlobal/HighestGoodNetworkApp#4679

Merged

Uh oh!

Conversation

Alforoan commented Jan 14, 2024

Description

Related PRS (if any):

Main changes explained:

How to test:

Uh oh!

nathanah Jan 27, 2024

Choose a reason for hiding this comment

Uh oh!

Alforoan Jan 31, 2024

Choose a reason for hiding this comment

Uh oh!

Renanluizssx left a comment

Choose a reason for hiding this comment

Uh oh!

Pandani07 left a comment

Choose a reason for hiding this comment

Uh oh!

galgalinidhi commented Feb 11, 2024

Uh oh!

mohabbasd left a comment

Choose a reason for hiding this comment

Uh oh!

XiaohanMeng left a comment

Choose a reason for hiding this comment

Uh oh!

skaush21 commented Feb 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jingyii800 left a comment

Choose a reason for hiding this comment

Uh oh!

chrischenlixing left a comment

Choose a reason for hiding this comment

Uh oh!

MALAV1308 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

brandta-1 left a comment

Choose a reason for hiding this comment

Review

Uh oh!

DiegoSalas27 commented Mar 10, 2024

Uh oh!

rajnada commented Mar 19, 2024

Uh oh!

hetvi11110 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iven-yao left a comment

Choose a reason for hiding this comment

Uh oh!

Coops023 left a comment

Choose a reason for hiding this comment

Uh oh!

Tiantian-C left a comment

Choose a reason for hiding this comment

Uh oh!

SRamen1999 left a comment

Choose a reason for hiding this comment

Uh oh!

Gayathr-2012 commented Mar 27, 2024

Uh oh!

kylepham left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kylepham Apr 2, 2024

Choose a reason for hiding this comment

Uh oh!

Kavil-Jain-514 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nyelmela left a comment

skaush21 commented Feb 21, 2024 •

edited

Loading

MALAV1308 left a comment •

edited

Loading

hetvi11110 left a comment •

edited

Loading

Kavil-Jain-514 left a comment •

edited

Loading