Skip to content

Yu Yan taking over for Ujjwal - fix: project report piechart visualization #4031

Closed
ujjwalbPipKcK wants to merge 2 commits intodevelopmentfrom
ujjwalbaranwal_fix_project_piechart_visualization
Closed

Yu Yan taking over for Ujjwal - fix: project report piechart visualization #4031
ujjwalbPipKcK wants to merge 2 commits intodevelopmentfrom
ujjwalbaranwal_fix_project_piechart_visualization

Conversation

@ujjwalbPipKcK
Copy link
Contributor

Description

Please include the exact bug/functionality description and a summary of the changes/ related issues. Please also include any other relevant motivation and context:

image

Video: https://www.loom.com/share/c177e2f6c87c4005aad39dff9b99460f?sid=1a103e3c-dc92-4e62-9c2f-3b8c52f5305e

image

Video: https://drive.google.com/file/d/1Yl4CFf2yjRINe8chVIkw98kZsPPvFvWv/view

Fixes # (Priority: Medium)

Related PRS (if any):

None Required

Main changes explained:

  • Updated the text color for the details above the pie chart to white in Dark Mode
  • Fixed the Issue when both Pie Charts were active, toggling the Button for the 2nd Pie Chart would toggle it for the first Pie Chart
  • Reworked the Show All Details feature to allow labels with a simple collision-avoidance

How to test:

  1. Check into current branch
  2. Do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. Go to Dashboard → Reports → Reports → Projects
  5. Select any Project name and Toggle the Checkboxes to view PieCharts (Example: /projectreport/6689dbd6c5e25463a05bcc9e)
  6. Verify the changes made (In Both Dark Mode and Light Mode)

Screenshots or videos of changes:

2025-09-05.21-59-44.mp4

Note:

Include the information the reviewers need to know.

@netlify
Copy link

netlify bot commented Sep 6, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit e8802e7
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/68bbc0fc431e0f000873ad21
😎 Deploy Preview https://deploy-preview-4031--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hemanthvenkat
Copy link

"Tested by navigating to Dashboard → Reports → Projects, toggling checkboxes to view PieCharts, and verifying in both Dark and Light modes. Working as expected."

PR4031.mp4

Copy link
Contributor

@jaydeep138 jaydeep138 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes and everything is working as expected.
• Pie charts correctly display project committed hours and all-time total hours.
• Toggle button behavior is functioning properly for both pie charts.
• Dark Mode updates are applied correctly (text color and toggle handling).

Approving this PR
Screenshot 2025-09-06 at 17 58 29

@AbhishekSrikanth
Copy link
Contributor

Working as expected. The checkboxes work, and the Pie charts are displayed, and they're interactive. Looks good on dark mode as well.

PR4031.mp4

@ujjwalbPipKcK ujjwalbPipKcK changed the title fix: project report piechart visualization Ujjwal - fix: project report piechart visualization Sep 12, 2025
Copy link
Contributor

@deep3072 deep3072 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the changes in dark mode and light mode.

  • The toggle functions work well with the pie chart and it reflects the changes
  • Dark mode change reflects proper color coding on the UI.

Approve.
Video: https://github.com/user-attachments/assets/e111e164-dce2-4fde-a4ea-40c8c6a2354e

Screenshot 2025-09-19 at 14 13 01

Copy link

@Swetha-1306 Swetha-1306 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR. All the checkboxes and toggles work fine, everything works as described.
Screenshot 2025-09-19 at 8 41 37 PM
Screenshot 2025-09-19 at 8 41 57 PM

Copy link
Contributor

@Prem203 Prem203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR with an admin account. The chart displays the data on clicking the checkbox and the toggle works correctly. The chart is displayed in both light and dark modes.

Although when the data is too compressed in all toggle, some of the names are overlapping. The UI is not responsive for all devices and the names are not visible in mobile screens.

image image image image image

@beblicarl
Copy link
Contributor

This feature worked as intended and the code is great

https://www.loom.com/share/ea712b0c417645d4a184d734a03bae08?sid=d7d845c1-9c14-4f8f-a706-03a0cd5ff2c7

@beblicarl beblicarl self-requested a review October 15, 2025 16:33
@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Dec 15, 2025
Copy link

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ujjwal,

I have reviewed your PR locally and the names are overlapping and are not visible in responsive mode, mobile screen.
Screenshot 2025-12-16 at 8 44 04 PM
Screenshot 2025-12-16 at 8 44 29 PM
Screenshot 2025-12-16 at 8 46 40 PM
Screenshot 2025-12-16 at 8 47 13 PM

@VijayAnirudh
Copy link

For some reason I cannot login. I've followed the exact same steps mentioned.
image
Please let me know If I'm doing something wrong!

Copy link

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation is sleek, really nicely done with the piechart (very smooth). Dark mode is working well.

PR 4031 Screenshot PR 4031 Screenshot 2 PR 4031 Screenshot 3 PR 4031 Screenshot 4

@one-community one-community changed the title Ujjwal - fix: project report piechart visualization Yu Yan taking over for Ujjwal - fix: project report piechart visualization Feb 23, 2026
@one-community one-community added do not review Do not review or look at code without full context and removed High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible Medium Priority labels Feb 24, 2026
@one-community
Copy link
Member

Redone with this #4928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not review Do not review or look at code without full context

Projects

None yet

Development

Successfully merging this pull request may close these issues.