Sayali: add Create Test Configuration button and modal to PR Grading Screen#4935
Open
sayali-2308 wants to merge 2 commits intodevelopmentfrom
Open
Sayali: add Create Test Configuration button and modal to PR Grading Screen#4935sayali-2308 wants to merge 2 commits intodevelopmentfrom
sayali-2308 wants to merge 2 commits intodevelopmentfrom
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
sayali-2308
added
the
High Priority - Please Review First
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements #33 (Priority High)
Related PRs:
Frontend PR related to Backend PR #2088 OneCommunityGlobal/HGNRest#2088
Also related to PR #4581 (Swathi - Fix for PR grading screen not visible)
Main changes explained:
CreateTestConfigModal.jsx— modal with fields for Team Name, Reviewer Count, Test Data Type, Reviewer Names, and Notes with full validation and dark mode supportCreateTestConfigModal.module.css— styling for modal with dark modePRGradingTest.jsx— integrated backend API to fetch configs on load, POST new config on create, DELETE config, loading spinner, and error handling via toastPRGradingScreen.jsx— fixed dark mode styling for PR number input fieldPRGradingTest.module.css— styling for config buttons in light and dark modesrc/utils/URL.js— addedPR_GRADING_CONFIGendpointHow to test:
Sayali_PR_Grading_Create_Test_Confignpm run build && npm run startnpm install && npm run start:localon frontend/pr-grading-test+ Create Test Configuration, fill form and submitScreenshots:
Note:
Backend PR OneCommunityGlobal/HGNRest#2088 must be running for configs to persist after page refresh. Static configs (91NePRT, SmallTeam, ComplexTeam) are hardcoded and always visible.