Skip to content

remove password from rdp file - it breaks rdp. Add application descri… #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MiriamMcMahon merged 1 commit into from
Jun 24, 2021
Merged

remove password from rdp file - it breaks rdp. Add application descri… #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions scripts/examples/examplePlugin.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@

#This example perl script is used to customise an rdp file generated by scalus before presenting it to Microsoft Remote Desktop
#
#set the password here if required from the output of :
my $spass="";
#uncomment and set the password here if required from the output of :
#("mypassword" | ConvertTo-SecureString -AsPlainText -Force) | ConvertFrom-SecureString;
my $spass="myencryptedpassword";

my $spassvalue="password 51:b:${spass}";
#$spass="myencryptedpassword";

my $filename=$ARGV[0];

Expand Down Expand Up @@ -36,10 +35,10 @@
chomp;
my ($key, $valtype, $val) = split /:/, $_;
if (not (exists $settings{$key})) {
if ($key ne "password 51")
if (($key ne "password 51") or ($spass == ""))
{
$settings{$key} = "${valtype}:${val}";
}
}
}

}
Expand All @@ -48,7 +47,10 @@
for (keys %settings) {
print TOFILE "$_:$settings{$_}\n";
}
print TOFILE "${spassvalue}\n";
if ($spass != "")
{
print TOFILE "password 51:b:${spass}";
}
close (TOFILE);

unlink(${filename});
Expand Down
1 change: 0 additions & 1 deletion scripts/examples/exampleRdpTemplate.rdp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,3 @@ use redirection server name:i:0
rdgiskdcproxy:i:0
kdcproxyname:s:
drivestoredirect:s:
password 51:b:myencryptedpassword
26 changes: 13 additions & 13 deletions src/scalus.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"Applications": [
{
"Id": "windows-rdp",
"Description": "Windows RDP Client",
"Description": "Run MS Windows RDP Client with a default connection file, which can be customized by the examplePlugin.pl perl script ",
"Name": "Windows RDP Client",
"Platforms": [ "Windows" ],
"Protocol": "rdp",
Expand All @@ -30,7 +30,7 @@
},
{
"Id": "windows-rdp-withtemplate",
"Description": "Windows RDP Client",
"Description": "Run MS Windows RDP Client with a user-supplied connection file: exampleRdpTemplate.rdp",
"Name": "Windows RDP Client with template",
"Platforms": [ "Windows" ],
"Protocol": "rdp",
Expand All @@ -45,7 +45,7 @@

{
"Id": "freerdp",
"Description": "FreeRDP",
"Description": "Run FreeRdp client with the supplied connection settings",
"Name": "FreeRDP",
"Platforms": [ "Linux" ],
"Protocol": "rdp",
Expand All @@ -58,7 +58,7 @@
},
{
"Id": "windows-openssh",
"Description": "Windows OpenSSH",
"Description": "Run the Windows OpenSSH client. An auth key can be provided by adding the '-i, keypath' arguments.",
"Name": "Windows OpenSSH",
"Platforms": [ "Windows" ],
"Protocol": "ssh",
Expand All @@ -67,27 +67,27 @@
"Options": []
},
"Exec": "C:\\windows\\system32\\cmd.exe",
"Args": [ "/c", "C:\\Windows\\System32\\OpenSSH\\ssh.exe", "%User%@%Host%" ]
"Args": [ "/c", "C:\\Windows\\System32\\OpenSSH\\ssh.exe -l %User% %Host%" ]
},

{
"Id": "gnome-terminal-ssh",
"Name": "Gnome Terminal SSH",
"Description": "Open Gnome Terminal on Linux with the SSH connection information",
"Description": "Run Open Gnome Terminal on Linux to connect to SSH. An SSH key can be provided by adding the '-i, keyfile' args",
"Platforms": [ "Linux" ],
"Protocol": "ssh",
"Parser": {
"ParserId": "ssh",
"Options": []
},
"Exec": "/usr/bin/gnome-terminal",
"Args": [ "-x", "ssh", "-t", "%User%@%Host%" ]
"Args": [ "-x", "ssh", "-t", "-l", "%User%", "%Host%" ]
},

{
"Id": "mac-ssh",
"Name": "MAC TerminalSSH",
"Description": "Open Terminal on Mac OS with the SSH connection information",
"Description": "Run Open Terminal on Mac OS with the SSH connection information",
"Platforms": [ "Mac" ],
"Protocol": "ssh",
"Parser": {
Expand All @@ -100,7 +100,7 @@
{
"Id": "mac-rdp",
"Name": "Mac RDP",
"Description": "Run MS Windows RDP on MAC",
"Description": "Run MS Windows RDP on MAC using default connection settings",
"Platforms": [ "Mac" ],
"Protocol": "rdp",
"Parser": {
Expand All @@ -118,7 +118,7 @@

{
"Id": "putty-ssh",
"Description": "Putty client",
"Description": "Run the Putty client to connect using SSH. An SSH key can be provided by adding the '-i, keyfile' args",
"Name": "Putty",
"Platforms": [ "Windows" ],
"Protocol": "ssh",
Expand All @@ -131,7 +131,7 @@
},
{
"Id": "putty-telnet",
"Description": "Putty client",
"Description": "Run the Putty client to connect using telnet",
"Name": "Putty Telnet",
"Platforms": [ "Windows" ],
"Protocol": "telnet",
Expand All @@ -144,7 +144,7 @@
},
{
"Id": "remmina-rdp",
"Description": "Use remmina client on linux",
"Description": "Run Remmina client on linux to connect to RDP using a user-supplied template:rdp.remmina",
"Name": "remmina Rdp client",
"Platforms": [ "Linux" ],
"Protocol": "rdp",
Expand All @@ -158,7 +158,7 @@
},
{
"Id": "remmina-ssh",
"Description": "Use remmina client on ubuntu",
"Description": "Run Remmina client on Linux to connect to SSH using a user-supplied template:ssh.remmina",
"Name": "remmina SSH client",
"Platforms": [ "Linux" ],
"Protocol": "ssh",
Expand Down