Implement the callback for the SignalR connection state. #129
Merged
bnicholesdell merged 1 commit intoOneIdentity:masterfrom Jul 20, 2023
Merged
Conversation
…s around connecting to the A2A signalr service and mark the A2A Persist event listener APIs that take a thumbprint as not supported. Connecting and authenticating to the A2A signalr service is handled differently than signalr on the core service. The core service authenticates using an access token via restsharp which is able to use the windows certificate store. It then uses Okhttp with the access token to connect to the signalr service. Connecting to the A2A signalr service is done entirely using okhttp and passing a certificate. Okhttp can't pull a certificate out of the windows certificate store by thumbprint. The problem is difference in the authentication methods when using Okhttp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the callback for the SignalR connection state. Fix some bugs around connecting to the A2A signalr service and mark the A2A Persist event listener APIs that take a thumbprint as not supported. Connecting and authenticating to the A2A signalr service is handled differently than signalr on the core service. The core service authenticates using an access token via restsharp which is able to use the windows certificate store. It then uses Okhttp with the access token to connect to the signalr service. Connecting to the A2A signalr service is done entirely using okhttp and passing a certificate. Okhttp can't pull a certificate out of the windows certificate store by thumbprint. The problem is difference in the authentication methods when using Okhttp.