bldr/docker_utils.py: froce remove if kill fails at exit#54
Open
gergo-nyiro-oi wants to merge 1 commit intoOneIdentity:masterfrom
Open
bldr/docker_utils.py: froce remove if kill fails at exit#54gergo-nyiro-oi wants to merge 1 commit intoOneIdentity:masterfrom
gergo-nyiro-oi wants to merge 1 commit intoOneIdentity:masterfrom
Conversation
The cleanup during the exit from `DockerContainer` context could fail because if docker couldn't kill the container it won't be able to remove it either. Therefore we kill the container with force option if the kill failed.
wferi
reviewed
May 22, 2025
Collaborator
wferi
left a comment
wferi
left a comment
There was a problem hiding this comment.
According to https://docker-py.readthedocs.io/en/stable/containers.html kill() already defaults to SIGKILL, and remove(force=True) sends SIGKILL as well. How can this patch make a difference then?
Author
|
Double stubbing just to be sure :) Joke aside, I have to recheck without force, but the logging may can help in the debugging in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cleanup during the exit from
DockerContainercontext could fail because if docker couldn't kill the container it won't be able to remove it either. Therefore we kill the container with force option if the kill failed.