[Bug]: PermissionsActivity does not follow app theme

[michael-winkler]

What happened?

If we request any permission with the default android implementation the dialog looks like this:

Statusbar and navigationbar is here transparent.

If we request the notification permission with the OneSignal implementation the dialog looks like this:

Why the difference? Can this please be improved?
The lines of the OneSignal Activity are here:

<activity android:name="com.onesignal.core.activities.PermissionsActivity"
                  android:theme="@android:style/Theme.Translucent.NoTitleBar"
                  android:exported="false" />

Steps to reproduce?

Just use the OneSignal code "OneSignal.Notifications.requestPermission(false)"

What did you expect to happen?

A better style for the theme like the default android permission dialogs!

OneSignal Android SDK version

5.1.23

Android version

14

Specific Android models

All

Relevant log output

-

Code of Conduct

• I agree to follow this project's Code of Conduct

[michael-winkler]

This can be fixed if we do following:

class PermissionsActivity : Activity() {
    private var requestPermissionService: RequestPermissionService? = null
    private var preferenceService: IPreferencesService? = null
    private var permissionRequestType: String? = null

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)

        if (!OneSignal.initWithContext(this)) {
            return
        }

        // Needed for the theme fix
        actionBar?.hide()

        requestPermissionService = OneSignal.getService()
        preferenceService = OneSignal.getService()

        handleBundleParams(intent.extras)
    }
...
}

Android Manifest:

<manifest xmlns:android="http://schemas.android.com/apk/res/android">

    <!-- Required so the device can access the internet. -->
    <uses-permission android:name="android.permission.INTERNET" />
    <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />

    <application>
        <service
          android:name="com.onesignal.core.services.SyncJobService"
          android:permission="android.permission.BIND_JOB_SERVICE"
          android:exported="false" />

        <activity android:name="com.onesignal.core.activities.PermissionsActivity"
                  android:theme="@style/PermissionsTheme"
                  android:exported="false" />
    </application>

    <!-- NOTE: See release version for tags with placeholders -->
</manifest>

<style name="PermissionsTheme">
    <item name="android:windowAnimationStyle">@android:style/Animation</item>
    <item name="android:windowBackground">@android:color/transparent</item>
    <item name="android:windowIsTranslucent">true</item>
    <item name="windowNoTitle">true</item>
    <item name="windowActionBar">false</item>
</style>

Can someone please try this? The issue is open since october last year and nothing happens.

[michael-winkler]

Still not fixed...

[michael-winkler]

Not fixed...

[fadi-george]

Hello, should be fixed in 5.7.4.