[Bug]: Crash on Android 6-7 when using SDK version 5.1.34 with a Gradle 7 project

[dmytroreutov]

What happened?

A lot of crashes happened recently when OneSignal Android SDK is updated. Seems like
Model.initializeFromJson() has code causing this crash.

Steps to reproduce?

1. Install SDK v5.1.34.
2. Launch app normally.
3. Send push to device.
4. Consecutive launches are failed with crash.

What did you expect to happen?

I expected no crash at startup

OneSignal Android SDK version

5.1.34

Android version

7.1, 7.0, 6

Specific Android models

Relevant log output

Caused by java.lang.NoSuchMethodError: No virtual method getParameterCount()I in class Ljava/lang/reflect/Method; or its super classes (declaration of 'java.lang.reflect.Method' appears in /system/framework/core-libart.jar)
       at com.onesignal.common.modeling.Model.initializeFromJson(Model.kt:101)
       at com.onesignal.common.modeling.SimpleModelStore.create(SimpleModelStore.kt:30)
       at com.onesignal.common.modeling.ModelStore.load(ModelStore.kt:175)
       at com.onesignal.common.modeling.SimpleModelStore.<init>(SimpleModelStore.kt:23)
       at com.onesignal.core.internal.config.ConfigModelStore.<init>(ConfigModelStore.kt:8)
       at java.lang.reflect.Constructor.newInstance(Constructor.java)
       at com.onesignal.common.services.ServiceRegistrationReflection.resolve(ServiceRegistration.kt:89)
       at com.onesignal.common.services.ServiceProvider.getServiceOrNull(ServiceProvider.kt:79)
       at com.onesignal.common.services.ServiceProvider.getService(ServiceProvider.kt:67)
       at com.onesignal.internal.OneSignalImp.initWithContext(OneSignalImp.kt:570)
       at com.onesignal.OneSignal.initWithContext(OneSignal.java:135)

Code of Conduct

• I agree to follow this project's Code of Conduct

[jkasten2]

@dmytroreutov Thanks for reporting. This issue happens if you are still using Gradle 7 / AGP (Android Gradle Plugin) 7. If you upgrade to Gradle 8 and AGP 8 this should fix the issue for you, however let us know if it does not.

Since Gradle 7 / AGP 7 is still somewhat common we will be addressing this issue in a future update.

[jkasten2]

A fix is now included in the 5.1.35 release