Add new remote params#1076
Merged
Jeasmine merged 4 commits intomajor_release_4.0.0from Aug 4, 2020
Merged
Conversation
Jeasmine
force-pushed
the
feature/remote-params
branch
from
1c71bdd to
e1a2472
Compare
Jeasmine
force-pushed
the
feature/remote-params
branch
from
e1a2472 to
cbd417a
Compare
Jeasmine
force-pushed
the
feature/remote-params
branch
4 times, most recently
from
54cfba8 to
130a023
Compare
mikechoch
reviewed
Jul 9, 2020
Contributor
mikechoch
left a comment
mikechoch
left a comment
There was a problem hiding this comment.
I think this branch should be rebased to major_release_4.0.0, looks like we are avoiding breaking changes in this PR but there should be breaking changes because we are removing specific variables and methods and replacing them with the remote param methods and defaults.
Jeasmine
force-pushed
the
feature/remote-params
branch
from
130a023 to
4066139
Compare
Jeasmine
force-pushed
the
feature/remote-params
branch
from
4066139 to
c9eee53
Compare
* Add unsubscribeWhenNotificationAreDisable remote param * Add disableGMSMissingPrompt remote param * Add locationShared remote param * Add requiresUserPrivacyConcent remote param * Keep public method * Add tests for new getters
Jeasmine
force-pushed
the
feature/remote-params
branch
from
c9eee53 to
736f3bb
Compare
* Move task management to TaskController * Delay task until remote params and init is done * After task delayed, check again for user consent * Fix test, add tests
mikechoch
suggested changes
Jul 31, 2020
Jeasmine
force-pushed
the
feature/remote-params
branch
2 times, most recently
from
ac30cb8 to
b43e72b
Compare
jkasten2
approved these changes
Aug 3, 2020
Member
jkasten2
left a comment
jkasten2
left a comment
There was a problem hiding this comment.
Just one nit on an extra if statement.
mikechoch
reviewed
Aug 4, 2020
Jeasmine
force-pushed
the
feature/remote-params
branch
from
b43e72b to
e7b5e3f
Compare
mikechoch
pushed a commit
that referenced
this pull request
Aug 13, 2020
* Add new remote params * Add unsubscribeWhenNotificationAreDisable remote param * Add disableGMSMissingPrompt remote param * Add locationShared remote param * Add requiresUserPrivacyConcent remote param * Keep public method * Add tests for new getters * Add task delay due to requiring consent from remote params * Move task management to TaskController * Delay task until remote params and init is done * After task delayed, check again for user consent * Fix test, add tests * Remove extra check/schedule on pending tasks
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is