Return setLocationShared and setRequiresUserPrivacyConsent methods#1124
Merged
Jeasmine merged 2 commits intomajor_release_4.0.0from Aug 27, 2020
Merged
Return setLocationShared and setRequiresUserPrivacyConsent methods#1124Jeasmine merged 2 commits intomajor_release_4.0.0from
Jeasmine merged 2 commits intomajor_release_4.0.0from
Conversation
* Keep remote param methods logic * Mark as deprecated setLocationShared and setRequiresUserPrivacyConsent
jkasten2
requested changes
Aug 22, 2020
Jeasmine
force-pushed
the
fix/return-remote-params-methods
branch
2 times, most recently
from
6389ee8 to
04f55f8
Compare
* Avoid remote params being override by user * Add test for new logic
Jeasmine
force-pushed
the
fix/return-remote-params-methods
branch
from
04f55f8 to
a582c80
Compare
jkasten2
approved these changes
Aug 27, 2020
Member
There was a problem hiding this comment.
Looks good to me!
Due note that if the presents of a remote param overrides the local value then the backend will need to allow for 3 options.
- undefined ("Not Set", driven by local value)
- Enabled
- Disabled
@Jeasmine It this wasn't noted in this PR but want to confirm this is what is intended by this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for reference: OneSignal/OneSignal-iOS-SDK#707
This change is