Checking shouldLogUserPrivacyConsentErrorMessage for Outcomes

[emawby]

Currently OneSignal crashes if an App sends outcomes or unique outcomes when requires privacy consent is true.
Now we will log an error message and return instead.

---

This change is 

[jkasten2]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @emawby, @Jeasmine, and @nan-li)

---

OneSignalSDK/onesignal/src/main/java/com/onesignal/OneSignal.java, line 3293 at r1 (raw file):

      }

      if (shouldLogUserPrivacyConsentErrorMessageForMethodName("sendOutcome()")) {

Failing test that looks related to this changes:
https://app.travis-ci.com/github/OneSignal/OneSignal-Android-SDK/builds/235207484#L2091-L2098

We might have to move this after the taskRemoteController below.

[emawby]

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @Jeasmine, @jkasten2, and @nan-li)

---

OneSignalSDK/onesignal/src/main/java/com/onesignal/OneSignal.java, line 3293 at r1 (raw file):

Previously, jkasten2 (Josh Kasten) wrote…

Failing test that looks related to this changes:
https://app.travis-ci.com/github/OneSignal/OneSignal-Android-SDK/builds/235207484#L2091-L2098

We might have to move this after the taskRemoteController below.

moved it below the queue task block!

[jkasten2]

LGTM

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Jeasmine and @nan-li)

[jkasten2]

Tests failed but seems we have a flaky unrelated test:

com.test.onesignal.GenerateNotificationRunner > shouldContainPayloadWhenOldSummaryNotificationIsOpened FAILED
    java.lang.Exception: Main looper has queued unexecuted runnables. This might be the cause of the test failure. You might need a shadowOf(getMainLooper()).idle() call.
        at org.robolectric.android.internal.AndroidTestEnvironment.checkStateAfterTestFailure(AndroidTestEnvironment.java:502)
        at org.robolectric.RobolectricTestRunner$HelperTestRunner$1.evaluate(RobolectricTestRunner.java:581)
        at org.robolectric.internal.SandboxTestRunner$2.lambda$evaluate$0(SandboxTestRunner.java:263)
        at org.robolectric.internal.bytecode.Sandbox.lambda$runOnMainThread$0(Sandbox.java:89)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at java.lang.Thread.run(Thread.java:748)
        Caused by:
        junit.framework.ComparisonFailure: expected:<UUID[2]> but was:<UUID[1]>
            at junit.framework.Assert.assertEquals(Assert.java:100)
            at junit.framework.Assert.assertEquals(Assert.java:107)
            at com.test.onesignal.GenerateNotificationRunner.shouldContainPayloadWhenOldSummaryNotificationIsOpened(GenerateNotificationRunner.java:346)