Conversation
cardViews have their own custom background where corner radius is applied. By setting the backgroundColor you remove the custom background and replace it with a new one that has the new color. To avoid this we should be using the setCardBackgroundColor instead. This changes the color on the custom background instead of replacing it.
jkasten2
approved these changes
Nov 10, 2021
Member
jkasten2
left a comment
There was a problem hiding this comment.
Change looks good to me. Would be nice to have a before and after screenshot since this is a visual fix.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Jeasmine and @nan-li)
nan-li
approved these changes
Nov 11, 2021
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fixing rounded corners for IAMs.
Details
cardViews have their own custom background where corner radius is applied. By setting the backgroundColor you remove the custom background and replace it with a new one that has the new color. To avoid this we should be using the setCardBackgroundColor instead. This changes the color on the custom background instead of replacing it.
Background context
This bug was initially introduced when we set the cardView's background to transparent to enable transparent IAMs.
Affected code checklist
Checklist
Overview
Testing
We don't currently have a way to visually unit test IAMs for details like rounded corners
Final pass
This change is