Skip to content

Reverting "Speculative Fix for WorkManager not Initialized Crash"#1753

Closed
nan-li wants to merge 1 commit intomainfrom
revert-1721-fix/speculative_work_manager_crash_fix
Closed

Reverting "Speculative Fix for WorkManager not Initialized Crash"#1753
nan-li wants to merge 1 commit intomainfrom
revert-1721-fix/speculative_work_manager_crash_fix

Conversation

@nan-li
Copy link
Copy Markdown
Contributor

@nan-li nan-li commented Mar 25, 2023

Reverts #1721

Description

One Line Summary

Reverts #1721 which was our speculative Fix for WorkManager not Initialized Crash, due to issues reported by early users.

Details

Motivation

Customers reporting lots of crashes (1 caught in QA and 1 in production)

Please see the original PR #1721 for details.

Testing

None, reverting.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

@nan-li nan-li closed this Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant