[5.0.0] Make subscribers in EventProducer synchronized#1796
Merged
emawby merged 1 commit intouser-model/mainfrom Aug 8, 2023
Merged
[5.0.0] Make subscribers in EventProducer synchronized#1796emawby merged 1 commit intouser-model/mainfrom
emawby merged 1 commit intouser-model/mainfrom
Conversation
This fixes a concurrentmodificationexception
nan-li
approved these changes
Aug 7, 2023
emawby
approved these changes
Aug 8, 2023
Merged
jinliu9508
pushed a commit
that referenced
this pull request
Jan 31, 2024
[5.0.0] Make subscribers in EventProducer synchronized
jinliu9508
pushed a commit
that referenced
this pull request
Jan 31, 2024
[5.0.0] Make subscribers in EventProducer synchronized
jinliu9508
pushed a commit
that referenced
this pull request
Feb 6, 2024
[5.0.0] Make subscribers in EventProducer synchronized
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Address ConcurrentModificationException crash by making subscribers in EventProducer synchronized
Details
Motivation
Customer issue of ConcurrentModificationException reported by Firebase Crashlytics while registering for push notifications.
Scope
Crash occurs while iterating over subscribers list in EventProducer.
Testing
Unit testing
No unit testing used for this fix. Future unit test could be written to create a multithreading environment.
Manual testing
Unable to reproduce original crash. Tested branch builds and push notifications registration is successful.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is