User model/remove throws#1802
Merged
emawby merged 4 commits intouser-model/mainfrom Aug 10, 2023
Merged
Conversation
jkasten2
approved these changes
Aug 10, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Don't throw uncaught exceptions for bad input or failed logins.
Details
Log errors instead of throwing if login fails and if bad inputs are sent to tags, subscriptions, and aliases.
Motivation
Don't crash on bad input or failed login
Testing
Manual testing
Tested adding aliases, tags, and subs with good and bad input.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is