Add refresh_device_metadata to create user so country / IP can be set#1911
Merged
nan-li merged 1 commit intouser-model/mainfrom Nov 17, 2023
Merged
Conversation
When the server receives a create user request, it doesn't automatically update IP and country for this user because this request can come from the SDK or from the customer's server. By passing in a `refresh_device_metadata = true` property to the request body, we can let the server know to update IP and country based on where the request originated from.
jkasten2
approved these changes
Nov 15, 2023
jennantilla
approved these changes
Nov 15, 2023
Merged
jinliu9508
pushed a commit
that referenced
this pull request
Jan 31, 2024
…o_create_user Add refresh_device_metadata to create user so country / IP can be set
jinliu9508
pushed a commit
that referenced
this pull request
Jan 31, 2024
…o_create_user Add refresh_device_metadata to create user so country / IP can be set
jinliu9508
pushed a commit
that referenced
this pull request
Feb 6, 2024
…o_create_user Add refresh_device_metadata to create user so country / IP can be set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Add
refresh_device_metadatato create user so country and IP can be set for the new user.Details
When the server receives a create user request, it doesn't automatically update IP and country for this user because this request can come from the SDK or from the customer's server.
By passing in a
refresh_device_metadata = trueproperty to the request body, we can let the server know to update IP and country based on where the request originated from.Motivation
Country and IP were missing on newly created users, and only set after they have a second session. Now, they will have country and IP on creation.
Scope
Country and IP are based on where the request originated from.
Testing
Unit testing
None
Manual testing
Android emulator on API 33
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is