[Player Model] Fix notification permission compile error#1933
Merged
Conversation
it's only used internally to the class
nan-li
approved these changes
Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix a compile error due to a syntax error introduced in PR #1848.
Details
Also cleaned up some warnings related to an unneeded annotation and scoping to private.
Motivation
Fix compile error so we can release the fix from PR #1848 and so future release can be made.
Scope
Only fixing issues related to
NotificationPermissionController.supportsNativePrompt.Fixes #1930
Testing
Unit testing
Manual testing
Tested on Android 14 emulator, ensure it prompts for notifications.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is