Keep banner-style IAMs on the screen while background is tapped#1999
Merged
Keep banner-style IAMs on the screen while background is tapped#1999
Conversation
* Revert the focusable property of the PopupWindow that displays an IAM view to be false. This was added as part of fullbleed IAM implementation in #1481, but does not appear to be necessary. * This allows banner-style top and bottom IAMs to remain on the screen while the user interacts with the app. * Otherwise, currently, tapping on the background dismisses the banner-style IAM.
jkasten2
approved these changes
Feb 21, 2024
This was referenced Feb 22, 2024
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Keep banner-style IAMs on the screen while background is tapped by changing the PopupWindow's focusable property to false.
Details
Motivation
Request from customer.
Improved banner IAM behavior.
Scope
Testing
Unit testing
None
Manual testing
Emulator Pixel 3 XL on API 33, with notch
Tested these IAMs before (on LEFT) and after (on RIGHT) to check behavior, it's a screen recording of two screen recordings:
all_iams.mov
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is