[PlayerModel] [Fix] make timeFocusedAtMs thread safe#2025
Merged
jkasten2 merged 1 commit intoplayer-model-mainfrom Mar 9, 2024
Merged
[PlayerModel] [Fix] make timeFocusedAtMs thread safe#2025jkasten2 merged 1 commit intoplayer-model-mainfrom
jkasten2 merged 1 commit intoplayer-model-mainfrom
Conversation
Fixes rare cases where timeFocusedAtMs can become null right after the null check in getTimeFocusedElapsed(). We have seen crashes in the wild so it not just theoretical.
emawby
approved these changes
Mar 9, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix rare
nullcrash withtimeFocusedAtMsby making it thread safe.Details
Motivation
A few customers have seen a rare crash.
Scope
Only affects focus time calculations.
Crash Example
Testing
Manual testing
Tested on an Android 14 emulator, ensuring the on_focus endpoint was called with the the correct time.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is