[PlayerModel] [Fix] make taskQueueWaitingForInit thread safe#2026
Merged
jkasten2 merged 1 commit intoplayer-model-mainfrom Mar 9, 2024
Merged
Conversation
There are two calls to startPendingTasks that can happen on two threads, which means sometimes taskQueueWaitingForInit.poll() can return null and throws a NPE when it is given to submit. To handle this we are making taskQueueWaitingForInit thread safe by calling synchronized on. Doing so handles this case but also rare cases where something is being added as we process the queue.
emawby
approved these changes
Mar 9, 2024
Base automatically changed from
fix/player-model-null-timeFocusedAtMs
to
player-model-main
March 9, 2024 01:10
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix rare null crash with taskQueueWaitingForInit.poll() by making
taskQueueWaitingForInitthread safe.Details
Motivation
A few customers get this rare NPE crash.
Scope
Only affects calls made to OneSignal before the SDK is initialized.
Related Issues
#1761
Crash Example
Testing
Manual testing
Tested on an Android 14 emulator ensuring a few things work like addTags.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is