Skip to content

[PlayerModel] [Fix] Retry starting new threads#2027

Merged
jkasten2 merged 1 commit intoplayer-model-mainfrom
fix/player-model-retry-new-threads
Mar 9, 2024
Merged

[PlayerModel] [Fix] Retry starting new threads#2027
jkasten2 merged 1 commit intoplayer-model-mainfrom
fix/player-model-retry-new-threads

Conversation

@jkasten2
Copy link
Copy Markdown
Member

@jkasten2 jkasten2 commented Mar 9, 2024

Description

One Line Summary

Handle Thread.start() throwing OutOfMemoryError errors by retrying.

Details

Motivation

App developers can handle onTrimMemory and might be cleaning up memory. While the SDK can't know if this is being done it's better to retry then to crash the app.

Scope

This commit doesn't cover all new threads, just some of the most common ones.
Also in v5 most new threads have been migrated to Kotlin coroutines so this PR should not be used outside of this player model branch.

Crash Examples

Crash 1

java.lang.OutOfMemoryError: pthread_create (1040KB stack) failed: Try again
  at java.lang.Thread.nativeCreate(Thread.java:-2)
  at java.lang.Thread.start(Thread.java:883)
  at com.onesignal.OneSignalRestClient.callResponseHandlerOnFailure(OneSignalRestClient.java:296)
  at com.onesignal.OneSignalRestClient.getThreadTimeout(OneSignalRestClient.java:260)
  at com.onesignal.OneSignalRestClient.startHTTPConnection(OneSignalRestClient.java:260)
  at com.onesignal.OneSignalRestClient.access$100(OneSignalRestClient.java:46)
  at com.onesignal.OneSignalRestClient$4.run(OneSignalRestClient.java:114)
  at java.lang.Thread.run(Thread.java:919)

Crash 2

java.lang.OutOfMemoryError: pthread_create (1040KB stack) failed: Try again
  at java.lang.Thread.nativeCreate(Thread.java:-2)
  at java.lang.Thread.start(Thread.java:733)
  at com.onesignal.OneSignal.registerUser(OneSignal.java:1499)
  at com.onesignal.OneSignal.access$400(OneSignal.java:86)
  at com.onesignal.OneSignal$6.complete(OneSignal.java:1099)
  at com.onesignal.PushRegistratorAbstractGoogle.internalRegisterForPush(PushRegistratorAbstractGoogle.java:71)
  at com.onesignal.PushRegistratorAbstractGoogle.registerForPush(PushRegistratorAbstractGoogle.java:51)
  at com.onesignal.OneSignal.registerForPushToken(OneSignal.java:1079)
  at com.onesignal.OneSignal.startRegistrationOrOnSession(OneSignal.java:1029)
  at com.onesignal.OneSignal.doSessionInit(OneSignal.java:1012)
  at com.onesignal.OneSignal.onAppFocusLogic(OneSignal.java:1438)
  at com.onesignal.OneSignal.onAppFocus(OneSignal.java:1420)
  at com.onesignal.OSFocusHandler.startOnFocusWork(OSFocusHandler.java:53)
  at com.onesignal.ActivityLifecycleHandler.handleFocus(ActivityLifecycleHandler.java:197)
  at com.onesignal.ActivityLifecycleHandler.onActivityResumed(ActivityLifecycleHandler.java:95)
  at com.onesignal.ActivityLifecycleListener.onActivityResumed(ActivityLifecycleListener.java:91)
  at android.app.Application.dispatchActivityResumed(Application.java:239)
  at android.app.Activity.onResume(Activity.java:1343)
  at androidx.core.app.ComponentActivity.onResume(ComponentActivity.java)
  at androidx.activity.ComponentActivity.onResume(ComponentActivity.java)
  at androidx.fragment.app.FragmentActivity.onResume(FragmentActivity.java:310)
  at androidx.appcompat.app.AppCompatActivity.onResume(AppCompatActivity.java)

Crash 3

java.lang.OutOfMemoryError: pthread_create (1040KB stack) failed: Try again
  at java.lang.Thread.nativeCreate(Thread.java:-2)
  at java.lang.Thread.start(Thread.java:883)
  at com.onesignal.OneSignalRestClient.makeRequest(OneSignalRestClient.java:118)
  at com.onesignal.OneSignalRestClient.$$c(OneSignalRestClient.java:118)
  at com.onesignal.OneSignalRestClient.putSync(OneSignalRestClient.java:96)
  at com.onesignal.UserStateSynchronizer.addOnSessionOrCreateExtras(UserStateSynchronizer.java:357)
  at com.onesignal.UserStateSynchronizer.doPutSync(UserStateSynchronizer.java:357)
  at com.onesignal.UserStateSynchronizer.getId(UserStateSynchronizer.java:357)
  at com.onesignal.UserStateSynchronizer.fireEventsForUpdateFailure(UserStateSynchronizer.java:285)
  at com.onesignal.UserStateSynchronizer.internalSyncUserState(UserStateSynchronizer.java:285)
  at com.onesignal.UserStateSynchronizer.updateIdDependents(UserStateSynchronizer.java:285)
  at com.onesignal.UserStateSynchronizer.syncUserState(UserStateSynchronizer.java:251)
  at com.onesignal.UserStateSynchronizer$NetworkHandlerThread$1.run(UserStateSynchronizer.java:141)
  at android.os.Handler.handleCallback(Handler.java:883)
  at android.os.Handler.dispatchMessage(Handler.java:100)
  at android.os.Looper.loop(Looper.java:214)
  at android.os.HandlerThread.run(HandlerThread.java:67)

Crash 4

java.lang.OutOfMemoryError: pthread_create (1040KB stack) failed: Try again
  at java.lang.Thread.nativeCreate(Thread.java:-2)
  at java.lang.Thread.start(Thread.java:883)
  at com.onesignal.OSBackgroundSync.doBackgroundSync(OSBackgroundSync.java:66)
  at com.onesignal.OSBackgroundSync.getSyncTaskId(OSBackgroundSync.java:66)
  at com.onesignal.SyncJobService.onStartJob(SyncJobService.java:40)
  at android.app.job.JobService$1.onStartJob(JobService.java:62)
  at android.app.job.JobServiceEngine$JobHandler.handleMessage(JobServiceEngine.java:108)
  at android.os.Handler.dispatchMessage(Handler.java:107)
  at android.os.Looper.loop(Looper.java:264)
  at android.app.ActivityThread.main(ActivityThread.java:7663)
  at java.lang.reflect.Method.invoke(Method.java:-2)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:980)

Testing

Manual testing

Ensured SDK run on an Android 14 emulator and network calls are being made.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
    - Test are not passing on player-model-main
  • [X I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Thread.start() can throw OutOfMemoryError errors and we can attempt to
start the thread again. App developers can handle onTrimMemory and might
be cleaning up memory. While the SDK can't know if this is being done
its better to retry then to crash the app.

This commit doesn't cover all new thread, just some of the most common
ones.

Also in v5 most new threads have been migrated to Kotlin coroutines so
this patch should not be used outside of this player model branch.
Base automatically changed from fix/player-model-null-taskQueueWaitingForInit.poll to player-model-main March 9, 2024 01:10
@jkasten2 jkasten2 merged commit d53f59e into player-model-main Mar 9, 2024
@jkasten2 jkasten2 deleted the fix/player-model-retry-new-threads branch March 9, 2024 01:12
@jkasten2 jkasten2 mentioned this pull request Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants