Conversation
jkasten2
changed the title
jkasten2
changed the title
jkasten2
requested review from
brismithers,
emawby,
jennantilla,
jinliu9508,
nan-li and
shepherd-l
jkasten2
force-pushed
the
improve/op_repo_restart_wait_on_every_enqueue
branch
from
c21cf48 to
1a77f1b
Compare
jkasten2
force-pushed
the
improve/handle_incorrect_404
branch
from
a8adb55 to
1c2bf82
Compare
We want to prevent a misbehaving app stuck in a loop from continuously sending updates every opRepoExecutionInterval (5 seconds currently). By waiting for the dust to settle we ensure the app is done making updates.
Every time something new is enqueued we will not restart waiting for batches timer. The motivation is to prevent a misbehaving app from continuously making network calls. We are basically saying wait for the "the dust to settle" or "the water is calm" to ensure the app is done making updates. FUTURE: Highly recommend not removing this "the dust to settle" logic, as it ensures any app stuck in a loop can't cause continuous network requests. If the delay is too long for legitimate use-cases then allow tweaking the opRepoExecutionInterval value or allow commitNow() with a budget.
jkasten2
force-pushed
the
improve/op_repo_restart_wait_on_every_enqueue
branch
from
1a77f1b to
b6b60c6
Compare
jinliu9508
approved these changes
Apr 22, 2024
Contributor
jinliu9508
left a comment
jinliu9508
left a comment
There was a problem hiding this comment.
LGTM!
Great to have a new unit test for this improvement too!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Further improve batching by restarting OperationRepo's delay on every enqueue call.
Details
Motivation
We want to prevent a misbehaving app stuck in a loop from continuously sending updates every
opRepoExecutionInterval(5 seconds currently). We also want to save more network calls for legitimate use-cases as well. Both of which are accomplished in this PRScope
Only affects OperationRepo's batching delay.
History
This "wait for the dust to settle" delay strategy was used for player update in 4.x.x.
Testing
Unit testing
Manual testing
Tested on an Android 13 emulator. Ensured login, sendTags, and toggle permission all works. Also ensured quickly toggling
optIn()/optOut()we don't make a network call until after 5 seconds of the last toggle.Affected code checklist
Checklist
Overview
Testing
Final pass
This change is