[Player Model] Fix OSTaskController crashing on LinkedBlockingQueue.poll() on Android 12#2062
Merged
jkasten2 merged 2 commits intoplayer-model-mainfrom Apr 25, 2024
Conversation
Android 12 has a bug where ConcurrentLinkedQueue.poll() can return the wrong value. This is rare but results in a few crash reports in OSTaskController, see issue #1761. To workaround this issue we switched to LinkedBlockingQueue.
Switch renaming usages of ConcurrentLinkedQueue to LinkedBlockingQueue to avoid a possible crash on Android 12, due to a bug it has with it. While we haven't gotten any crash reports of these usages they could happen. See previous commit, ef581d2, for more details.
emawby
approved these changes
Apr 25, 2024
nan-li
approved these changes
Apr 25, 2024
Merged
This was referenced Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix rare Android 12 crash with OSTaskController using ConcurrentLinkedQueue.
Details
Android 12 has a bug where
ConcurrentLinkedQueue.poll()can return the wrong value. This is rare but results in a few crash reports in OSTaskController, see issue #1761.To workaround this issue we switched to LinkedBlockingQueue. We have seen reports of crashing in OSTaskController, but we also are also addressing the usages in
UserStateSynchronizer.Related
Issue fixes issue #1761.
ConcurrentLinkedQueue is not used in 5.x.x, so no changes are need there.
Motivation
Crashes are rare, and limited to Android 12, but SDK should cause any crashes.
Scope
Effects some Queues used in
OSTaskControllerandUserStateSynchronizer.Testing
Unit testing
player-model-main unit tests are not running currently.
Manual testing
Tested on an Android 14 emulator. Ensuring the device subscribes and tags can be added.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is