[Fix] Continuation called with OneSignal.getNotifications().requestPermission does not fire when permission is already granted#2093
Merged
jinliu9508 merged 1 commit intomainfrom May 23, 2024
Conversation
jkasten2
requested changes
May 21, 2024
caea4da to
506f0b1
Compare
jkasten2
approved these changes
May 23, 2024
114b533 to
5326adb
Compare
Contributor
|
Can clean up the commit history? |
5326adb to
4f7cc32
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix a bug causing OneSignal.getNotifications().requestPermission with continuation not firing when permission is granted.
Details
Motivation
This will fix some wrappers that utilize a Java bridge (like Unity and Flutter) and await forever and never resolve.
Testing
Manual testing
Scenarios that I manually tested:
a. Notification permission is off:
1. prompt for permission and allow
2. request again and observe that no prompt shows up and the continuation is fired with permissionResult = true
b. Notification permission is off:
1. prompt for permission and dismiss both dialogs
2. observe that the continuation is fired with permissionResult = false
c. Notification permission is on:
1. request permission and observe that no prompt shows up and the continuation is fired with permissionResult = true
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is