Skip to content

Bump minimum FCM version #2102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jinliu9508 merged 1 commit into from
Jun 3, 2024
Merged

Bump minimum FCM version #2102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions OneSignalSDK/onesignal/notifications/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,11 @@ dependencies {

compileOnly('com.amazon.device:amazon-appstore-sdk:[3.0.1, 3.0.99]')

// firebase-messaging:18.0.0 is the last version before going to AndroidX
// firebase-messaging:19.0.0 is the first version using AndroidX
// firebase-messaging:21.0.0 introduces FirebaseMessaging.getToken API
// firebase-messaging:23.0.0 incoporates fix for SecurityException: Not allowed to bind to service
Copy link
Copy Markdown
Contributor

@nan-li nan-li May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have some comments above that are no longer relevant / we can add a comment about why moving to version 21...

    // firebase-messaging:18.0.0 is the last version before going to AndroidX
    // firebase-messaging:19.0.0 is the first version using AndroidX

Copy link
Copy Markdown
Contributor Author

@jinliu9508 jinliu9508 May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I have pushed the change for the comment.

api('com.google.firebase:firebase-messaging') {
version {
require '[19.0.0, 23.4.99]'
require '[21.0.0, 23.4.99]'
prefer '23.4.0'
}
}
Expand Down