Fix: Update onNotificationOpened to process each notification ID#2111
Merged
jennantilla merged 3 commits intomainfrom Jun 7, 2024
Merged
Fix: Update onNotificationOpened to process each notification ID#2111jennantilla merged 3 commits intomainfrom
jennantilla merged 3 commits intomainfrom
Conversation
f74b722 to
26efa2f
Compare
jkasten2
requested changes
Jun 6, 2024
Member
jkasten2
left a comment
There was a problem hiding this comment.
Logic itself looks correct, but there are some thing I would like to see cleaned up before merging so the code is more readable / doesn't misdirect.
- replace notificationId null check with early continue - create private helper method for getting latest notification Id
4cd4939 to
c270e28
Compare
jkasten2
approved these changes
Jun 6, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Update onNotificationOpened to process each notification ID
Details
Motivation
After customer reports of dropping CTR following upgrade from v4 to v5, it was discovered that clicking an unexpanded group notification results in only registering the click result for the final notification in the group. This PR restores the SDK behavior back to "default" of registering clicks on a per-notification basis when the entire group is clicked.
Testing
Manual testing
Tested on a Pixel 7 (Android 14) emulator that clicking an uncollapsed group notification results in the click being tracked for each notification.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is