Skip to content

Always retrieve push token#2118

Merged
rgomezp merged 1 commit intomainfrom
fix/fcm-push-token-bug
Jun 7, 2024
Merged

Always retrieve push token#2118
rgomezp merged 1 commit intomainfrom
fix/fcm-push-token-bug

Conversation

@rgomezp
Copy link
Copy Markdown
Contributor

@rgomezp rgomezp commented Jun 7, 2024

Description

One Line Summary

Fixes issue where FCM project is changed and push token is not updated on subscribed devices

Details

Motivation: Fetching the push token every time is in-line with how we did things prior to user model. Fixes issue where the push token is not updating when FCM project number changes. There are also other circumstances where a push token may become invalid.

Testing

Manual testing

Tested in Android emulator.

Affected code checklist

Tip: Click "Hide whitespace" for easier Github code-diff

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Motivation: in-line with how we did things prior to user model

Fixes issue where FCM project is changed and push token is not updated on subscribed devices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants