[Player Model] The getter for WorkManager considers the app context#2123
Merged
nan-li merged 1 commit intoplayer-model-mainfrom Jun 13, 2024
Merged
Conversation
jkasten2
approved these changes
Jun 12, 2024
* We were getting the WorkManager instance via `WorkManagerImpl.getInstance()` and initializing it with a blank Configuration when the getter returned null. * However, we should use `WorkManagerImpl.getInstance(Context)` instead as this getter will allow for on-demand initialization with the app's custom WorkManager.
3e2f3ee to
baf9213
Compare
Merged
This was referenced Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Allow custom work manager to be initialized on demand, which resolves Hilt dependency manager conflict.
Details
isInitialized()API that checks for a WorkManager instance viaWorkManagerImpl.getInstance()and initializing it with a blank Configuration when the getter returned null.WorkManagerImpl.getInstance(Context)instead as this getter will allow for on-demand initialization with the app's custom WorkManager.lateinitmay not have the WorkManager instance initialized at the time we check.Motivation
CoroutineWorkers #1748Scope
Work Manager initialization.
Testing
Unit testing
Manual testing
Limited ability to test manually due to unable to reproduce original crash
Tested a client-supplied sample Hilt project and appears to resolve the problems.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is