[Fix] Permissions returned by onRequestPermissionResult is empty#2180
Merged
jinliu9508 merged 1 commit intomainfrom Sep 5, 2024
Merged
[Fix] Permissions returned by onRequestPermissionResult is empty#2180jinliu9508 merged 1 commit intomainfrom
jinliu9508 merged 1 commit intomainfrom
Conversation
jkasten2
approved these changes
Sep 4, 2024
Merged
This was referenced Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Add a null check on the permission list returned by onRequestPermissionResult, and handle it as a permission denial if the list is empty.
Details
Motivation
The current codebase assumes that onRequestPermissionResult always returns at least one permission. This can cause the app to crash in rare scenarios where the permission request is interrupted, resulting in an empty permission list. We have now added handling for this situation, and the permission will be denied by default if this occurs.
Scope
Both notification and location permission requests will be affected and will be handled the same in case the permission list returned from system is empty.
Testing
Manual testing
NOTE: I am unable to force reproduce the crash either manually or by simulation. However, I have tested other normal permission requesting behaviors to ensure that it does not interrupt the existing permission features.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is